CLOUD-3128 - EAP 7.2 UBI OpenShift image #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgdoliveira
previously approved these changes
May 3, 2019
luck3y
force-pushed
the
eap72-openjdk11-ubi8-dev
branch
5 times, most recently
from
a4dda80
to
db37809
Compare
bstansberry
requested changes
May 7, 2019
cp-overrides.yaml
Outdated
| - name: cct_module | ||
| git: | ||
| url: https://github.com/jboss-openshift/cct_module | ||
| ref: master |
There was a problem hiding this comment.
sprint-35?
Not master.
rel-overrides.yaml
Outdated
| - name: cct_module | ||
| git: | ||
| url: https://github.com/jboss-openshift/cct_module | ||
| ref: master |
There was a problem hiding this comment.
sprint-35?
Not master.
|
Yes to squash and will fix sprints. |
luck3y
force-pushed
the
eap72-openjdk11-ubi8-dev
branch
from
c1805ff
to
cce40d5
Compare
|
@bstansberry Fixed and squashed. |
bstansberry
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/CLOUD-3128
Signed-off-by: Ken Wills kwills@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s