Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUD-3122] - EAP CD - OpenJDK 11 / UBI #248

Merged
merged 1 commit into from Jun 19, 2019

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Jun 18, 2019

https://issues.jboss.org/browse/CLOUD-3122
Signed-off-by: Ken Wills kwills@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@luck3y
Copy link
Collaborator Author

luck3y commented Jun 18, 2019

@bstansberry I left this at CD 16 for now, as introducing CD17 stuff when the artifact we're actually building with is really 16 seemed to be inconsistent. The only remaining changes for 17 needed is a module update in jboss-eap-7-image to provide the zip and then introducing a version 17.0 config module with standalone-openshift.xml in it. For 17.0 we should only have one config, and the default DB drivers should be dropped (mysql & postgres) from the config.

Also requires jboss-container-images/jboss-eap-modules#117 for the config module.

@luck3y luck3y requested a review from bstansberry June 18, 2019 22:56
@luck3y
Copy link
Collaborator Author

luck3y commented Jun 18, 2019

@jfdenise FYI

@bstansberry
Copy link
Collaborator

+1 re sticking to 16. My main goal was to get this branch onto JDK 11 / UBI 8. Upgrading the zip is a different task.

@bstansberry
Copy link
Collaborator

@luck3y LGTM

@luck3y luck3y changed the title [CLOUD-3122] - EAP CD - Initial support for OpenJDK 11 / UBI [CLOUD-3122] - EAP CD - OpenJDK 11 / UBI Jun 19, 2019
@luck3y luck3y merged commit cec1853 into jboss-container-images:eap-cd-dev Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants