Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup overrides #339

Closed
wants to merge 1 commit into from
Closed

Cleanup overrides #339

wants to merge 1 commit into from

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Mar 31, 2020

https://issues.redhat.com/browse/CLOUD-3532
Signed-off-by: Ken Wills kwills@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@luck3y luck3y requested review from jfdenise and jmesnil March 31, 2020 16:20
@luck3y
Copy link
Collaborator Author

luck3y commented Mar 31, 2020

The idea here is to just have the required branches / versions in image.yaml and avoid the duplication in the overrides files.

@luck3y luck3y closed this Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfdenise jfdenise Awaiting requested review from jfdenise

@jmesnil jmesnil Awaiting requested review from jmesnil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@luck3y