CLOUD-3860 EAP XP 2.0 OpenShift Image #394
Conversation
eap-xp/image.yaml
Outdated
| - name: eap-xp-10-env | ||
| version: "1.0.3" | ||
| - name: eap-xp-20-env | ||
| version: "2.0.0" |
There was a problem hiding this comment.
Just a note, as this module is specific to EAP XP2 (eap-xp-20-env), its version should not be tied to 2.0 (it can start with 1.0.0).
There was a problem hiding this comment.
Do we want to start with :1.0? I can update these at the same time as making the other changes below.
There was a problem hiding this comment.
ok, let's then start at "1.0". thanks!
There was a problem hiding this comment.
@luck3y sorry, I completely missed something (that @jfdenise spotted).
We can not make these changes in the eap-xp directory as we must continue to be able to produce EAP XP 1 images.
Could you move all these files to a eap-xp2 directory so that we are able to produce EAP XP 1 and EAP XP2 images independently. thanks!
|
@jmesnil +1, will do this right now. |
|
Moved to eap-xp2 subdir, as requested. |
eap-xp2/image.yaml
Outdated
|
|
||
| name: "jboss-eap-7/eap-xp2-openjdk11-openshift-rhel8" | ||
| description: "Red Hat JBoss Enterprise Application Platform XP 2.0 OpenShift container image." | ||
| version: "1.0" |
There was a problem hiding this comment.
the version of the image should match the version of the EAP XP release to be consistent with our versioning scheme.
E.g current EAP 7 image is at 7.3.4:
There was a problem hiding this comment.
+1, I had it this way originally, but when we switched over to the new subdir, I thought this should match the version of XP1, which we started at :1.0, but is a bit ambigious. Will update this to be :2.0 again.
eap-xp2/runtime-image/image.yaml
Outdated
|
|
||
| name: "jboss-eap-7/eap-xp2-openjdk11-runtime-openshift-rhel8" | ||
| description: "Red Hat JBoss Enterprise Application Platform XP 2.0 OpenShift runtime image with OpenJDK 11" | ||
| version: "1.0" |
eap-xp2/image.yaml
Outdated
| - name: jboss.container.eap.s2i.galleon | ||
| - name: jboss.container.eap.galleon | ||
| - name: jboss.container.eap.galleon.config.mp | ||
| - name: jboss.container.eap.galleon.eap73-compat |
There was a problem hiding this comment.
This module is only required for 1.x and 7.3.x, it should be removed.
|
@luck3y thanks |
https://issues.redhat.com/browse/CLOUD-3860
Signed-off-by: Ken Wills kwills@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s