[7.2.x-openjdk11] - CLOUD-2742 - Allow kubernetes to control probe retries; avoid probes taking longer than kubernetes timeout settings #115
Conversation
luck3y
changed the title
luck3y
changed the title
|
@bstansberry Any thoughts on this one? |
…taking longer than kubernetes timeout settings
|
This is g2g now. |
| if [ $# -gt 1 ] ; then | ||
| SLEEP=$2 | ||
| fi | ||
| # setting the first parameter to true/false, gets you the new default behaviour of |
There was a problem hiding this comment.
Things are getting complicated. Usage section will be very helpful.
I must say misusing COUNT parameter for boolean true of false (doesnt matter which) is very confusing
Why are we keeping old behaviour. For eap64 stream? Doesnt eap64 stream have own branch?
There was a problem hiding this comment.
@mchoma For the existing images (7.2.x on OCP 3.x) we felt that adding additional parameters for OCP 4.1 would be problematic for the user as they'd have to change depending on which version of OCP they were using. So we provided the true / false mechanism as a way to switch between these behaviours.
This is only for the 7.2.x images, the internal retry is dropped for CD 17 and later images.
https://issues.jboss.org/browse/CLOUD-2742
Upstream PR: #116
Signed-off-by: Ken Wills kwills@redhat.com