[JBEAP-18124] fixing transaction_isolation setting for non-xa datasou… #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, istudens. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. Available Commands: /help Display this help text. /ok-to-test Add the user to the approved list of testers and run tests. /retest Rerun all tests. |
|
@luck3y Could you review this please? I am going to port it back to other branches once it is reviewed. Thanks. |
|
/ok-to-test |
|
@istudens LGTM, thanks! |
luck3y
approved these changes
Jan 21, 2020
|
@istudens At a minimum you'll need a matching PR for this against the 7.2.x-openjdk11 and 7.3.x-legacy branches too. Does the same issue exist in master? |
This was referenced Jan 22, 2020
|
PRs for 7.2.x-openjdk11 and 7.3.x-legacy branches filed. I am not sure about master. I am not even able to run tests there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rces
https://issues.redhat.com/browse/JBEAP-18124