CLOUD-3091 - Update builds to not use cacher #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmann
reviewed
Feb 21, 2019
| @@ -7,7 +7,7 @@ execute: | |||
| user: '185' | |||
|
|
|||
| artifacts: | |||
| - path: txn-recovery-marker-jdbc-common-1.1.2.Final-redhat-00001.jar | |||
| - name: txn-recovery-marker-jdbc-common-1.1.2.Final-redhat-00001.jar | |||
There was a problem hiding this comment.
I suggest to use something like this:
- name: txn-recovery-marker-jdbc-common
target: txn-recovery-marker-jdbc-common-1.1.2.Final-redhat-00001.jar
md5: cd68ad886a759d21f8dd0cb7646601eeSame applies to other artifacts.
There was a problem hiding this comment.
Ah, I see, so it can be overriden via name. Clever :)
bstansberry
previously approved these changes
Feb 28, 2019
bstansberry
dismissed
their stale review
I'm dismissing my review not because I think this is wrong but because reading the comments on the JIRA I realize I don't know if there are problems.
|
@bstansberry this PR should be all set I think, not sure what the other issues might be from reading the jira. |
|
FYI, this is causing issues for folks building images, someone approve it please :) |
bstansberry
approved these changes
Mar 7, 2019
luck3y
added a commit
to luck3y/jboss-eap-modules
that referenced
this pull request
Apr 18, 2019
* CLOUD-3091 - Update builds to not use cacher * update use name / target / md5
luck3y
added a commit
to luck3y/jboss-eap-modules
that referenced
this pull request
Apr 23, 2019
luck3y
added a commit
that referenced
this pull request
Apr 25, 2019
CLOUD-3175 - Update builds to not use cacher (#58) [7.2.x]
yersan
pushed a commit
to yersan/jboss-eap-modules
that referenced
this pull request
Oct 4, 2019
Adding tests for GC_METASPACE_SIZE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/CLOUD-3091
Signed-off-by: Ken Wills kwills@redhat.com