Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUD-3176] drop deprecated openshift.KUBERNETES_PING and openshift.DNS_PING in favor of upstream implementations #73

Merged
merged 2 commits into from Apr 23, 2019
Merged

[CLOUD-3176] drop deprecated openshift.KUBERNETES_PING and openshift.DNS_PING in favor of upstream implementations #73

merged 2 commits into from Apr 23, 2019

Conversation

luck3y
Copy link
Collaborator

@luck3y luck3y commented Apr 18, 2019

@luck3y luck3y requested a review from bstansberry April 19, 2019 03:29
@bstansberry
Copy link
Collaborator

Can this log something when it does this switch?

@luck3y
Copy link
Collaborator Author

luck3y commented Apr 23, 2019

Sure yeah, I'll add a log message.

@wildfly-ci
Copy link
Collaborator

Build 303 outcome was FAILURE using a merge of a445f51
Summary: Tests failed: 3 (3 new), passed: 110 Build time: 00:00:14

Failed tests

Generate JGroups ping config - openshift.KUBE_PING: Generate JGroups ping config - openshift.KUBE_PING


Generate JGroups ping config - openshift.DNS_PING: Generate JGroups ping config - openshift.DNS_PING


Generate JGroups ping config - openshift.DNS_PING with socket binding: Generate JGroups ping config - openshift.DNS_PING with socket binding

@luck3y
Copy link
Collaborator Author

luck3y commented Apr 23, 2019

@bstansberry Log message added, the duplication is somewhat ugly, but its temporary, probably until CD17.

@luck3y
CLOUD-3176 - drop deprecated openshift.KUBERNETES_PING and openshift.…
a2f6d11 
…DNS_PING in favor of upstream implementations

update tests
@luck3y luck3y merged commit 8e073e0 into jboss-container-images:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
approved dev-approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luck3y @bstansberry @wildfly-ci