Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUD-3199] - added warn message in case of SSO_SECRET is empty #86

Merged
merged 1 commit into from May 9, 2019

Conversation

ricardozanini
Copy link
Contributor

Signed-off-by: Ricardo Zanini zanini@redhat.com

Please see:
https://issues.jboss.org/browse/CLOUD-3199

@ricardozanini
Copy link
Contributor Author

ricardozanini commented May 7, 2019

@luck3y I decided to keep the same "warn logic" like the others warns in the script file. This warn is just a help message for users that don't link the keycloak subsystem error message with the SSO_SECRET parameter.

@luck3y
Copy link
Collaborator

luck3y commented May 7, 2019

@ricardozanini Thanks.

@iankko Jan, this look OK to you? We're wondering if just logging a warn is OK here. The server boot will probably fail due to the invalid subsytem config.

@luck3y luck3y self-assigned this May 7, 2019
@luck3y luck3y requested review from iankko and luck3y May 7, 2019 20:30
luck3y
luck3y previously approved these changes May 7, 2019
@ricardozanini
Copy link
Contributor Author

@luck3y @iankko the server will boot and pod won't fail, but this WARN will be there intermittently:

16:15:58,005 WARN  [org.keycloak.adapters.authentication.ClientIdAndSecretCredentialsProvider] (pool-25-thread-1) Client 'root' doesn't have secret available
16:15:58,013 ERROR [org.keycloak.adapters.NodesRegistrationManagement] (pool-25-thread-1) failed to register node to keycloak
16:15:58,013 ERROR [org.keycloak.adapters.NodesRegistrationManagement] (pool-25-thread-1) status from server: 400
16:15:58,013 ERROR [org.keycloak.adapters.NodesRegistrationManagement] (pool-25-thread-1)    {"error":"unauthorized_client","error_description":"INVALID_CREDENTIALS: Invalid client credentials"}

The integration won't work until the user generates a secret in the RH-SSO console and then set this secret to the SSO_SECRET parameter in the deploymentconfig/container ENV.

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants