[CLOUD-3918] - EAP 7.4.0.Beta Release Imagestreams and templates #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put back the missing eap74-beta-starter-s2i.json template Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
|
@luck3y I did a diff with the existing basic template and the only actual changes are the resources (services, env vars) related to MQ and Clustering. |
luck3y
approved these changes
Feb 23, 2021
|
I can confirm our test is passing with this template. |
|
@mchoma are you checking the presence of the template or verifying that it can deploy an app on OpenShift Online Started Edition? |
I am checking deploy of app on OpenShift (Not |
|
Are you going to merge this? |
|
Yep :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put back the missing eap74-beta-starter-s2i.json template
Signed-off-by: Jeff Mesnil jmesnil@redhat.com