[JBEAP-23324] Fix warning due to incorrect value of ImageStream and T… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soul2zimate
approved these changes
Mar 7, 2022
|
The imagestreams look fine, but templates typically contain multiple objects, each of which need to be handled, e.g. Route's v1 => route.openshift.io/v1 etc. Those APIs (e.g. Service) which are documented as core/v1 stay as "v1". |
jmesnil
requested changes
May 19, 2022
There was a problem hiding this comment.
@mackaypeter could you please update this PR based on @yselkowitz feedback?
The changes should be aligned with what @soul2zimate did in #43
|
@mackaypeter Any update on this? Thanks! |
|
Ping? |
…emplate apiVersion.
|
Updated the PR. I'll run a quick test, and then this can be merged. |
jmesnil
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emplate apiVersion.
Issue: https://issues.redhat.com/browse/JBEAP-23324