Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-134] Enhance KieServerStateOpenShiftRepository #165

Merged
merged 2 commits into from Mar 13, 2019

Conversation

rhtevan
Copy link
Contributor

@rhtevan rhtevan commented Feb 26, 2019

Adding a runtime configuration parameter in terms of system property and environment variable for enabling BC/WB KIE server global discovery.

Related JIRA

  • Pull Request title is properly formatted: [RHDM-XYZ] Subject or [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@rhtevan rhtevan force-pushed the KIECLOUD-134 branch 2 times, most recently from 06e1d16 to af5c2ac Compare March 6, 2019 15:59
@rhtevan
Copy link
Contributor Author

rhtevan commented Mar 6, 2019

@errantepiphany The leading PR (kiegroup/droolsjbpm-integration#1739) has been merged into the master. So it is ready to merge this following PR so that it can be cherry-picked into 7.3.1. BTW, rebased from master, should be no conflict.

@errantepiphany errantepiphany self-requested a review March 6, 2019 19:32
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtevan Perhaps change one of the tests by setting the env var to true? I ask because false is the default, so testing for false doesn't test that a different env var value was picked up. After that, I will merge the PR, however then we'll need another PR for the 7.3.x branch (with the cherry-picked commit in it). That PR will be labeled "on hold" until after the 7.3.x branch gets tagged as 7.3.0.GA, at which point we can merge PRs that are intended for 7.3.1.

@rhtevan
Copy link
Contributor Author

rhtevan commented Mar 7, 2019

@errantepiphany Good point. Moved away from using the default value in tests. And as per your suggestion, created another PR against 7.3.x branch. But for some reason, not able to set the 'on hold' label for that PR

@rhtevan rhtevan force-pushed the KIECLOUD-134 branch 2 times, most recently from 3217dea to a54c53a Compare March 12, 2019 14:04
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@errantepiphany errantepiphany merged commit 7bbb9a4 into jboss-container-images:master Mar 13, 2019
@rhtevan rhtevan deleted the KIECLOUD-134 branch March 13, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants