New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIECLOUD-134] Enhance KieServerStateOpenShiftRepository #165
[KIECLOUD-134] Enhance KieServerStateOpenShiftRepository #165
Conversation
06e1d16
to
af5c2ac
Compare
@errantepiphany The leading PR (kiegroup/droolsjbpm-integration#1739) has been merged into the master. So it is ready to merge this following PR so that it can be cherry-picked into 7.3.1. BTW, rebased from master, should be no conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhtevan Perhaps change one of the tests by setting the env var to true? I ask because false is the default, so testing for false doesn't test that a different env var value was picked up. After that, I will merge the PR, however then we'll need another PR for the 7.3.x branch (with the cherry-picked commit in it). That PR will be labeled "on hold" until after the 7.3.x branch gets tagged as 7.3.0.GA, at which point we can merge PRs that are intended for 7.3.1.
@errantepiphany Good point. Moved away from using the default value in tests. And as per your suggestion, created another PR against 7.3.x branch. But for some reason, not able to set the 'on hold' label for that PR |
3217dea
to
a54c53a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a runtime configuration parameter in terms of system property and environment variable for enabling BC/WB KIE server global discovery.
Related JIRA
[RHDM-XYZ] Subject
or[RHPAM-XYZ] Subject
CONTRIBUTING.md
)Signed-off-by: Your Name <yourname@example.com>
- usegit commit -s