[RHDM-871] Missing property org.kie.workbench.profile in DecisionCent… #177
Conversation
| # Business Central is unified for RHDM and RHPAM; For rhpam-decisioncentral image needs to be set | ||
| # org.kie.workbench.profile to FORCE_PLANNER_AND_RULES | ||
| if [[ $JBOSS_PRODUCT =~ rhdm\-decisioncentral? ]]; then | ||
| JBOSS_KIE_ARGS="${JBOSS_KIE_ARGS} -Dorg.kie.workbench.profile=FORCE_PLANNER_AND_RULES" |
There was a problem hiding this comment.
For RHPAM the org.kie.workbench.profile should be set to FORCE_FULL, to have same configuration as in on premise.
jakubschwan
force-pushed
the
master
branch
2 times, most recently
from
e6d8207
to
d63341a
Compare
There was a problem hiding this comment.
Thanks for the PR, @jakubschwan . Please seem my comment on the regular expression. Also, We will need a separate PR for the 7.3.x branch (as this one is for master).
| # Business Central is unified for RHDM and RHPAM; For rhpam-decisioncentral needs to be set org.kie.workbench.profile | ||
| # to FORCE_PLANNER_AND_RULES and for rhpam-businesscentral and rhpam-businesscentral-monitoring needst to be set to | ||
| # FORCE_FULL | ||
| if [[ $JBOSS_PRODUCT =~ rhdm\-decisioncentral? ]]; then |
There was a problem hiding this comment.
The regular expression on this line is incorrect, as the question mark at the end means that the final character (the lowercase letter L) is optional. (Zero or one occurrences.) Instead, no regular expression is needed here, and the check can just be of full string equality:
if [ "$JBOSS_PRODUCT" = "rhdm-decisioncentral" ]; then
The reason that there is a question mark in the business central case is that the entire grouping of (\-monitoring) can happen zero or one times, so that both "rhpam-businesscentral" and "rhpam-businesscentral-monitoring" would match. The "zero or one occurrence" affects everything in the parenthesis, whereas without the parenthesis, it would only apply to the last character.
…ral OpenShift image Signed-off-by: Jakub Schwan <jschwan@redhat.com>
|
@errantepiphany thanks for review, PR adjusted and new one for 7.3.x branch was opened (#178) |
…ral OpenShift image
https://issues.jboss.org/browse/RHDM-871
Signed-off-by: Jakub Schwan jschwan@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[RHDM-XYZ] Subjector[RHPAM-XYZ] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s