Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix templates doc generation #193

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

spolti
Copy link
Member

@spolti spolti commented Mar 19, 2019

If a DeploymentConfig has a containers section without envs and ports the generation will fail.

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHDM-XYZ] Subject or [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

If a DeploymentConfig has a containers section without envs and ports the generation will fail.
@spolti spolti merged commit 223da42 into jboss-container-images:master Mar 19, 2019
@spolti spolti deleted the fixGenDocs branch March 19, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants