Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHDM-319] OpenShift - default Maven user should not be admin #24

Closed
wants to merge 1 commit into from
Closed

Conversation

errantepiphany
Copy link
Collaborator

https://issues.jboss.org/browse/RHDM-319

Signed-off-by: David Ward dward@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

Signed-off-by: David Ward <dward@redhat.com>
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the way you implement that, just one thing, can you also add tests for it?

@errantepiphany
Copy link
Collaborator Author

Closing in favor of #26.

@errantepiphany errantepiphany deleted the RHDM-319 branch April 20, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants