Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-209] add sha512 and no-color options to build-overrides.sh #240

Merged
merged 1 commit into from
May 6, 2019
Merged

[KIECLOUD-209] add sha512 and no-color options to build-overrides.sh #240

merged 1 commit into from
May 6, 2019

Conversation

errantepiphany
Copy link
Collaborator

[KIECLOUD-209] add sha512 and no-color options to build-overrides.sh
https://issues.jboss.org/browse/KIECLOUD-209

Signed-off-by: David Ward dward@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [KIECLOUD-XYZ] Subject, [RHDM-XYZ] Subject or [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@errantepiphany errantepiphany requested a review from spolti May 6, 2019 21:15
@errantepiphany errantepiphany added the ready 🚀 work completed and ready to be merged label May 6, 2019
@tmckayus
Copy link
Contributor

tmckayus commented May 6, 2019

@errantepiphany looks good to me, the option from build-osbs.sh works, I did local test with a build.

The only thing I noticed is that there is not a short-option for no-color, and I don't see it in the help (but that might be intentional)

tmckayus
tmckayus previously approved these changes May 6, 2019
Signed-off-by: David Ward <dward@redhat.com>
@errantepiphany
Copy link
Collaborator Author

We're running out of meaningful single letters for short options, so that's on purpose. However, I did add the long option to the help (good catch).

@errantepiphany errantepiphany merged commit 0906e85 into jboss-container-images:7.3.x May 6, 2019
@errantepiphany errantepiphany deleted the KIECLOUD-209_7.3.x branch May 6, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready 🚀 work completed and ready to be merged
2 participants