Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHDM-894][RHPAM-2016] Update RHDM and RHPAM images to use RHEL8 (UBI) base layer #242

Merged
merged 1 commit into from May 13, 2019
Merged

[RHDM-894][RHPAM-2016] Update RHDM and RHPAM images to use RHEL8 (UBI) base layer #242

merged 1 commit into from May 13, 2019

Conversation

errantepiphany
Copy link
Collaborator

[RHDM-894] Update RHDM images to use RHEL8 (UBI) base layer
https://issues.jboss.org/browse/RHDM-894

[RHPAM-2016] Update RHPAM images to use RHEL8 (UBI) base layer
https://issues.jboss.org/browse/RHPAM-2016

Signed-off-by: David Ward dward@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [KIECLOUD-XYZ] Subject, [RHDM-XYZ] Subject or [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@errantepiphany errantepiphany added master ⇨ 7.4.0 wip 🚧 work in progress and not ready to be merged labels May 7, 2019
@errantepiphany errantepiphany requested a review from spolti May 7, 2019 09:06
spolti
spolti previously approved these changes May 8, 2019
View reviewed changes
@spolti
Copy link
Member

spolti commented May 8, 2019

Approved but, my my only concern is about the jdbc driver versions to make sure the versions that we are adding to the images are in the matrix support.

@errantepiphany
Copy link
Collaborator Author

errantepiphany commented May 8, 2019 •
edited

@spolti I don't think the particular versions of the postgresql and mariadb jdbc drivers would be included in the official UBI8 channels if they weren't supported themselves. However regarding the support "matrix" (I'm assuming you mean those drivers with EAP 7.2.1), we'll have to check...

@errantepiphany
Copy link
Collaborator Author

@spolti Update: Ken pointed me here, so it looks like they are in the support matrix:
"JBoss EAP 7.2 Tested Integrations"
https://access.redhat.com/articles/2026253

@errantepiphany
Copy link
Collaborator Author

@spolti One more concern, though...
Do we need to worry about any relationship between these DB changes, and rhpam-7-openshift-image/templates/contrib/jdbc ?

@errantepiphany errantepiphany added ready 🚀 work completed and ready to be merged and removed wip 🚧 work in progress and not ready to be merged labels May 8, 2019
@spolti
Copy link
Member

spolti commented May 10, 2019

@spolti One more concern, though...
Do we need to worry about any relationship between these DB changes, and rhpam-7-openshift-image/templates/contrib/jdbc ?

I don't think so as for now we can use custom driver names for ejb timer.

spolti
spolti previously approved these changes May 10, 2019
View reviewed changes
@errantepiphany
[RHDM-894][RHPAM-2016] Update RHDM and RHPAM images to use RHEL8 (UBI…
1020b62 
…) base layer

Signed-off-by: David Ward <dward@redhat.com>
@errantepiphany errantepiphany merged commit ec10693 into jboss-container-images:master May 13, 2019
@errantepiphany errantepiphany deleted the RHDM-894_RHPAM-2016_master branch May 13, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolti spolti spolti left review comments

Assignees
No one assigned
Labels
ready 🚀 work completed and ready to be merged
Milestone
No milestone
2 participants
@errantepiphany @spolti