Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHPAM-2261] - DB2 fails with externaldb template #300

Merged
merged 1 commit into from Aug 29, 2019
Merged

RHPAM-2261] - DB2 fails with externaldb template #300

merged 1 commit into from Aug 29, 2019

Conversation

spolti
Copy link
Member

@spolti spolti commented Aug 12, 2019

Signed-off-by: Filippe Spolti fspolti@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [KIECLOUD-XYZ] Subject, [RHDM-XYZ] Subject or [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@spolti spolti added ready 🚀 work completed and ready to be merged master ⇨ 7.5.0 labels Aug 12, 2019
errantepiphany
errantepiphany previously approved these changes Aug 12, 2019
View reviewed changes
@spolti spolti added wip 🚧 work in progress and not ready to be merged and removed ready 🚀 work completed and ready to be merged labels Aug 14, 2019
@spolti spolti force-pushed the RHPAM-2261 branch 2 times, most recently from 1d693d4 to 6419ead Compare August 15, 2019 21:16
errantepiphany
errantepiphany previously approved these changes Aug 16, 2019
View reviewed changes
@errantepiphany errantepiphany self-requested a review August 26, 2019 13:58
@spolti spolti added ready 🚀 work completed and ready to be merged and removed wip 🚧 work in progress and not ready to be merged labels Aug 28, 2019
@spolti spolti force-pushed the RHPAM-2261 branch 3 times, most recently from 8df4393 to fb6a0c6 Compare August 29, 2019 00:04
errantepiphany
errantepiphany requested changes Aug 29, 2019
View reviewed changes
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting a follow-up task jira for 7.6.0 to remove the workaround. Other than that, I'm cool with all the code changes. Thanks!

jboss-kie-kieserver/added/launch/jboss-kie-cli-datasource-patch.sh Outdated Show resolved Hide resolved
jboss-kie-kieserver/added/openshift-launch.sh Show resolved Hide resolved
@spolti
RHPAM-2261] - DB2 fails with externaldb template
7c9f6ce 
Signed-off-by: Filippe Spolti <fspolti@redhat.com>
@spolti spolti merged commit dcb463e into jboss-container-images:master Aug 29, 2019
@spolti spolti deleted the RHPAM-2261 branch August 29, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errantepiphany errantepiphany errantepiphany approved these changes

Assignees
No one assigned
Labels
ready 🚀 work completed and ready to be merged
Milestone
No milestone
2 participants
@spolti @errantepiphany