[RHPAM-2310] Add jboss-kie-module for process migration service #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errantepiphany
added
7.12.x ⇨ 7.12.0
errantepiphany
requested changes
Sep 11, 2019
jboss-kie-process-migration/added/configuration/application-roles.properties
Outdated
Show resolved
Hide resolved
jboss-kie-process-migration/added/configuration/application-users.properties
Outdated
Show resolved
Hide resolved
errantepiphany
changed the title
spolti
requested changes
Sep 11, 2019
jboss-kie-process-migration/added/configuration/application-roles.properties
Outdated
Show resolved
Hide resolved
|
@spolti @errantepiphany please review the new approach. Thanks |
|
@ruromero looks like your branch does n ot have the circleci configuration file, do you mind to rebase your branch? |
|
@spolti done |
|
@ruromero I forget to ask you before (sry), but do you mind to add your bats tests on the circleci configuration file as well? |
|
@spolti done! |
spolti
previously approved these changes
Sep 13, 2019
errantepiphany
added
ready 🚀
errantepiphany
previously approved these changes
Sep 13, 2019
|
@ruromero Please squash the commits? |
ruromero
dismissed stale reviews from errantepiphany and spolti
via
977e6b6
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
errantepiphany
approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Romero Montes rromerom@redhat.com
Fix https://issues.jboss.org/browse/RHPAM-2310
Adds jboss-kie-module for process migration service including scripts and default configurations to be used in the resulting image.
Allows configuring extra classpath entries (that would be provided inside the image) and additional configuration file to override defaults.