[RHPAM-2175] Use only adminUser in all the scripts #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
errantepiphany
added
7.12.x ⇨ 7.12.0
errantepiphany
approved these changes
Jan 22, 2020
spolti
approved these changes
Jan 23, 2020
jakubschwan
reviewed
Feb 3, 2020
| else | ||
| log_info "Make sure to configure the KIE_SERVER_USER user to interact with KIE Server rest api with the roles $(get_kie_server_roles)" | ||
| fi | ||
| if [ "${KIE_ADMIN_USER}x" != "x" ]; then |
There was a problem hiding this comment.
@ruromero Is print_user_information() still needed? If I looked correctly is it no more used in scripts.
If we would like to have it include as an info log when user is created in any BA component, we should add print_user_information() back as it was removed in PR #348
Also can you please check tests if they are passing? Because user information print was removed from workbench as well - see in PR here
There was a problem hiding this comment.
It is indeed dead code, let me know what do you think about this PR #354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Romero Montes rromerom@redhat.com
https://issues.redhat.com/browse/RHPAM-2175