Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHPAM-3162] - WSS - Wrong URL generated in secure communication betw… #386

Merged
merged 1 commit into from Sep 16, 2020
Merged

[RHPAM-3162] - WSS - Wrong URL generated in secure communication betw… #386

merged 1 commit into from Sep 16, 2020

Conversation

spolti
Copy link
Member

@spolti spolti commented Sep 15, 2020 •
edited

…een BC and KS in OCP

Signed-off-by: spolti fspolti@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [KIECLOUD-XYZ] Subject, [RHDM-XYZ] Subject or [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@spolti
[RHPAM-3162] - WSS - Wrong URL generated in secure communication betw…
3efe5bb 
…een BC and KS in OCP

Signed-off-by: spolti <fspolti@redhat.com>
@spolti spolti added the ready 🚀 work completed and ready to be merged label Sep 15, 2020
@kie-ci-bot kie-ci-bot bot added the needs review 🔍 Pull Request that needs reviewers label Sep 15, 2020
desmax74
desmax74 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@desmax74 desmax74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jakubschwan
jakubschwan approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice tests 👍

@spolti spolti merged commit 9bcb79a into jboss-container-images:master Sep 16, 2020
@spolti spolti mentioned this pull request Sep 16, 2020
Merged
7 tasks
@spolti spolti deleted the RHPAM-3162 branch June 23, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desmax74 desmax74 desmax74 approved these changes

@jakubschwan jakubschwan jakubschwan approved these changes

@msmagnanijr msmagnanijr Awaiting requested review from msmagnanijr

Assignees
No one assigned
Labels
needs review 🔍 Pull Request that needs reviewers ready 🚀 work completed and ready to be merged
Milestone
No milestone
3 participants
@spolti @desmax74 @jakubschwan