[CLOUD-2297] - Support Quartz configuration with Oracle and another D… #51
Conversation
| QUARTZ_DELEGATE_CLASS="org.quartz.impl.jdbcjobstore.oracle.OracleDelegate" | ||
| # Oracle classes needs to be accessible by the quartz, in this case oracle driver needs to be added on jboss-deployment-structure.xml file | ||
| if [ "x${QUARTZ_DRIVER}" != "x" ]; then | ||
| sed -i "s|<\!--EXTRA_DEPENDENCY-->|<module name=\"deployment.${QUARTZ_DRIVER}\"/>\n <\!--EXTRA_DEPENDENCY-->|" $JBOSS_HOME/standalone/deployments/kie-server.war/WEB-INF/jboss-deployment-structure.xml |
There was a problem hiding this comment.
This expects the driver to be installed as a deployment, however, the driver could also be installed as a module
e.g., as described here
https://blog.openshift.com/conntecting-to-an-external-oracle-database/
it would perhaps be better to explicitly ask for a "QUARTZ_DRIVER_MODULE" , to let the user provide anything, not necessarily with "deployment." prefix (and describe it in the documentation)
There was a problem hiding this comment.
@maschmid I agree with you, thanks, and sry for the delay, I completely forgot about it =/
@errantepiphany sure thing.
spolti
added
the
on hold ⏳
spolti
force-pushed
the
CLOUD-2297
branch
3 times, most recently
from
622ad2e
to
0cc36ed
Compare
| sed -i "s|USE \[enter_db_name_here\]|USE ${databaseName}|" $JBOSS_HOME/bin/quartz_tables_sqlserver.sql | ||
|
|
||
| elif [[ "${KIE_SERVER_PERSISTENCE_DIALECT}" == "org.hibernate.dialect.DB2"* ]]; then | ||
| if [ "x${KIE_SERVER_PERSISTENCE_SCHEMA}" != "x" ]; then |
There was a problem hiding this comment.
I don't think it is strictly DB2 specific (even I have only seen it used there).
Also it isn't strictly quartz specific, isn't there a more appropritte place to put it in the scripts?
There was a problem hiding this comment.
Yeah, Good point, I do remember to use it a long time ago with oracle.
I'll move this change next to the place where the kie.persistence.ds and dialect is configured.
spolti
removed
the
on hold ⏳
…atabases Fix ctf tests. Signed-off-by: Filippe Spolti <fspolti@redhat.com>
|
@errantepiphany can you please re-approve? |
…atabases
Signed-off-by: Filippe Spolti fspolti@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s