[CLOUD-2235] add reference to kie-modules #35
Conversation
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Name scheme change to avoid clashes with the same modules in the older repository. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
| - name: os-kieserver-s2i | ||
| - name: os-kieserver-webapp | ||
| - name: os-kieserver-chmod | ||
| - name: os.kieserver.launch |
There was a problem hiding this comment.
Can we use a more descriptive name, e.g. like Java package name for these? The goal being to be able to easily identify from which repository the module is pulled, e.g. jboss.kie.kieserver.launch: kieserver.launch module from jboss-kie repsoitory. If you have a better idea for naming, feel free to adjust as necessary. With the example I provided, you might also want to add a name to the repo, e.g. jboss.kie.repo. Having a name is a critical piece required to override the module location for development purposes, e.g. overrides.yaml:
modules:
repositories:
- name: jboss.kie.repo
path: /home/me/src/git/jboss-container-images/jboss-kie-modulesThere was a problem hiding this comment.
@rcernich I like this idea (changing the names), but can we do this as follow-up PRs? There's already a lot in this jira...
There was a problem hiding this comment.
After speaking with @rcernich on IRC, the renaming of modules (and adding repo names) will be done in subsequent PRs. We need to move these PRs so other work can progress.
https://issues.jboss.org/browse/CLOUD-2235
KIE modules are moving repositories; make sure we reference the new location.
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -sSigned-off-by: Jonathan Dowland jdowland@redhat.com