Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-390] fix JAVA_HOME for runtime images #214

Merged

Conversation

jmtd
Copy link
Member

@jmtd jmtd commented May 20, 2021

The path /usr/lib/jvm/jre exists in both images, the prior
values do not.

https://issues.redhat.com/browse/OPENJDK-390

The path /usr/lib/jvm/jre exists in both images, the prior
values do not.

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. There should be a behave test for it. Something like $JAVA_HOME/bin/java -version should be sufficient.

@jmtd
Copy link
Member Author

jmtd commented May 24, 2021

@jerboaa agreed!

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
@jmtd jmtd force-pushed the OPENJDK-390-fix-runtime-java-home branch from 0f30c8f to b1debf7 Compare May 24, 2021 09:18
@jmtd jmtd requested a review from jerboaa May 24, 2021 09:31
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmtd jmtd merged commit 78f8ddd into jboss-container-images:develop Jun 15, 2021
@jmtd jmtd deleted the OPENJDK-390-fix-runtime-java-home branch June 15, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants