Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-575] Adding IBM Semeru 11 CE module and a trial yaml file #265

Merged

Conversation

levivic
Copy link
Contributor

@levivic levivic commented Jan 28, 2022

Hi @jerboaa and @jmtd, as you may already know, there is a strong push from Oracle of switching from IBM Semeru Open Edition to Certified Edition for all the Openj9 related images we release in RH by the end of March. Aside from all the business and legal discussions, the management team wants us to validate using the existing RH release proc and toolchains to achieve this transition from pure technical perspective. The process includes building the rpm from srpm (provided by IBM), adding semeru-11-ce modules, and updating all image override files to include the new module/package, like what we did for Semeru open edition.

I have prepared the semeru-11-certified (only 11 on rhel8 for now) module and I would like to invite you to review it. Since there are some difference between the ce and oe versions. And the module itself is crucial for all other images using it.

I have also added an override yaml file for this image. I'm sure there could be more changes coming, i.e, the downstream repos/branches, image names, signing intent, etc., when a final decision is made about this transition. So for those changes I would be less concerned at this moment.

Thanks in advance for any feedback!

https://issues.redhat.com/browse/OPENJDK-575
Signed-off-by: Lei Zhang lzhan@redhat.com

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Just a few minor comments.

semeru-ce-11-rhel8.yaml Outdated Show resolved Hide resolved
semeru-ce-11-rhel8.yaml Outdated Show resolved Hide resolved
@levivic
Copy link
Contributor Author

levivic commented Jan 31, 2022

@jerboaa thanks for the comments!

@jmtd
Copy link
Member

jmtd commented Feb 1, 2022

I've kicked off the GItHub CI jobs for this PR, I have no reason to think that this PR should influence or cause problems for the other images, but we might as well wait for the green lights before merging.

@jmtd jmtd merged commit 998f8cf into jboss-container-images:develop Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants