[OPENJDK-1335] microdnf update weak deps #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure images do not have a set of RPMs installed which are not hard dependencies of OpenJDK or Maven but might get installed as transitive weak dependencies if microdnf is not configured with install_weak_deps=0 Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
|
The new test passed for ubi8/openjdk-8 but shouldn't have. I think it's a race condition, due to using "available container log". I'm going to try just "container log". This unfortunately means a 30s wait per step in the scenario, but "correct" trumps "fast". |
This is potentially racy. Use 'container log' instead. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
jerboaa
reviewed
Dec 22, 2022
modules/util/pkg-update/execute.sh
Outdated
| @@ -4,7 +4,7 @@ set -euo pipefail | |||
| for candidate in yum dnf microdnf; do | |||
| if command -v "$candidate"; then | |||
| mgr="$(command -v "$candidate")" | |||
| "$mgr" update -y | |||
| "$mgr" update --setopt=install_weak_deps=0 -y | |||
There was a problem hiding this comment.
Please also set --setopt=tsflags=nodocs that's what regular install commands have as well.
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
jmtd
force-pushed
the
OPENJDK-1335-microdnf-update-weak-deps
branch
from
3b81c0d
to
6b7030a
Compare
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
jmtd
force-pushed
the
OPENJDK-1335-microdnf-update-weak-deps
branch
from
d8e2234
to
760d7cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of a 2-commit PR: I want to see CI red lights for this commit before pushing the fix.
This commit adds a test for some RPMs that are installed as transitive weak dependencies via microdnf when it is not configured with install_weak_deps=0.
https://issues.redhat.com/browse/OPENJDK-1335?filter=12398815