Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-2868 OpenJDK 11 RHEL8 image + CLOUD-2867 OpenJDK 8/RHEL 8 #76

Merged
merged 12 commits into from May 1, 2019

Conversation

jmtd
Copy link
Member

@jmtd jmtd commented Apr 11, 2019

https://issues.jboss.org/browse/CLOUD-2868

This depends upon the following changes made to cct_module:

jboss-openshift/cct_module#335

https://issues.jboss.org/browse/CLOUD-2868

This depends upon the following changes made to cct_module:

jboss-openshift/cct_module#335

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
@jmtd
Copy link
Member Author

jmtd commented Apr 11, 2019

Problems to fix:

  • the image contains OpenJDK 8 too
  • failing tests:
    • features/image/java/java_s2i.feature:9 Check incremental builds cache .m2
    • features/image/java/java_s2i.feature:309 Check java perf dir owned by jboss (CLOUD-2070)
  • "/usr/local/s2i/run: line 15: /opt/jboss/container/maven/default//scl-enable-maven: No such file or directory"

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
@jmtd
Copy link
Member Author

jmtd commented Apr 11, 2019

The perf dir check, at least, is failing because "spring-boot-sample-simple" from https://github.com/jboss-openshift/openshift-examples is terminating shortly after start-up:

start-up logs

/usr/local/s2i/run: line 15: /opt/jboss/container/maven/default//scl-enable-maven: No such file or directory
Starting the Java application using /opt/jboss/container/java/run/run-java.sh ...
INFO exec  java -javaagent:/opt/jboss/container/jolokia/jolokia.jar=config=/opt/jboss/container/jolokia/etc/jolokia.properties -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:Ma
xHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=100m -XX:+ExitOnOutOfMemoryError -cp "." -jar /deployments/spring-boot-sample-simple-1.5.0
.BUILD-SNAPSHOT.jar  
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jolokia.util.ClassUtil (file:/opt/jboss/container/jolokia/jolokia-jvm-1.5.0.redhat-1-agent.jar) to constructor sun.security.x509.X500Name
(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
WARNING: Please consider reporting this to the maintainers of org.jolokia.util.ClassUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
I> No access restrictor found, access to any MBean is allowed
Jolokia: Agent started with URL https://172.17.0.2:8778/jolokia/

Is jolokia the problem here?

@jmtd
Copy link
Member Author

jmtd commented Apr 11, 2019

Is jolokia the problem here?

No, disabling it with AB_JOLOKIA_OFF does not fix.

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.springframework.cglib.core.ReflectUtils$1 (jar:file:/deployments/spring-boot-sample-simple-1.5.0.BUILD-SNAPSHOT.jar!/BOOT-INF/lib/spring-
core-4.3.4.RELEASE.jar!/) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of org.springframework.cglib.core.ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Possibly just this version of spring boot does not work with JDK 11?

@jmtd
Copy link
Member Author

jmtd commented Apr 11, 2019

The perf thing is (at least) jboss-openshift/openshift-examples#38

Remove elaborate pgrep|xargs stuff, pgrep is in procps-ng which is not
installed by default in our UBI image, but the Java PID is guaranteed
to be jboss-container-images#1 anyway since we exec it from the runner script on purpose.

Switch to the undertow-servlet quickstart as the repository to base
the test on; the sprintboot example doesn't remain running for more
than a second or so and so is not suited for tests that rely on it
running (all the other instances of it in this file appear to be
checking static properties so it doesn't matter as much for those)

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
@jmtd jmtd changed the title CLOUD-2868 OpenJDK 11 RHEL8 image CLOUD-2868 OpenJDK 11 RHEL8 image + CLOUD-2867 OpenJDK 8/RHEL 8 Apr 18, 2019
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
rhel8 → ubi8. This leaves namespace for a future non-UBI8
RHEL8 image, although I don't expect we will ever have one.

jdk8 → jdk1.8, and avoid contracting "1.8" to "18" which
would eventually cause us problems.

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
@jmtd jmtd merged commit 7ef166d into jboss-container-images:develop May 1, 2019
@jmtd jmtd deleted the CLOUD-2868-RHEL8-JDK11 branch May 1, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant