Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sso75-dev] [RHSSO-1937] Ensure expiry works in Infinispan #257

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

iankko
Copy link
Collaborator

@iankko iankko commented Sep 2, 2022

Note: This is a replacement of #244 one, but/just created against the sso75-dev branch (to be able to process it).

[RHSSO-1937] Ensure expiry works in Infinispan

Setting any lifespan will enable the Infinispan reaper process to remove expired entries. This avoids an OOM situation.

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

Setting any lifespan will enable the Infinispan reaper process to remove expired entries. This avoids an OOM situation.

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@iankko iankko self-assigned this Sep 2, 2022
@iankko
Copy link
Collaborator Author

iankko commented Sep 2, 2022

@ahus1 @pedroigor jFYI

@iankko
Copy link
Collaborator Author

iankko commented Sep 2, 2022

Testing/candidate RH-SSO container image (to prove the work of this) was built within #582 container pipeline run.

@iankko
Copy link
Collaborator Author

iankko commented Sep 2, 2022

Brief manual testing of the aforementioned image to prove OIDC/SAML client adapters (on top of EAP 7.4 container image) works against this RH-SSO container image:

...
[2022-09-02 06:02:37,178] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testHtml5AdminUser is starting *** 
[2022-09-02 06:02:55,649] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testHtml5AdminUser succeeded after 0:00:18.464 *** 
[2022-09-02 06:02:55,659] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testHtml5NonUser is starting *** 
[2022-09-02 06:03:12,537] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testHtml5NonUser succeeded after 0:00:16.878 *** 
[2022-09-02 06:03:12,544] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testHtml5User is starting *** 
[2022-09-02 06:03:29,481] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testHtml5User succeeded after 0:00:16.937 *** 
[2022-09-02 06:03:29,486] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJaxrServiceIsBearerOnly is starting *** 
[2022-09-02 06:03:29,865] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJaxrServiceIsBearerOnly succeeded after 0:00:00.378 *** 
[2022-09-02 06:03:29,871] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJeeAdmin is starting *** 
[2022-09-02 06:03:47,214] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJeeAdmin succeeded after 0:00:17.343 *** 
[2022-09-02 06:03:47,222] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJeeNonuser is starting *** 
[2022-09-02 06:04:01,382] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJeeNonuser succeeded after 0:00:14.160 *** 
[2022-09-02 06:04:01,392] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJeeUser is starting *** 
[2022-09-02 06:04:18,893] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.testJeeUser succeeded after 0:00:17.501 *** 
[2022-09-02 06:04:18,932] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.zzzTestLogoutWorksWithOfflineSso is starting *** 
[2022-09-02 06:05:46,753] INFO -  *** Test com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest.zzzTestLogoutWorksWithOfflineSso succeeded after 0:01:27.820 *** 
[WARNING] Tests run: 12, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 558.421 s - in com.redhat.xpaas.sso.registration.ExamplesAutomaticRegistrationTest
[INFO] 
[INFO] Results:
[INFO] 
[WARNING] Tests run: 12, Failures: 0, Errors: 0, Skipped: 4
[INFO] 
...

The change LGTM AFAICT, merging.

@iankko iankko merged commit 32ccfb1 into jboss-container-images:sso75-dev Sep 2, 2022
@iankko iankko deleted the RHSSO-1937 branch September 2, 2022 10:56
@ahus1
Copy link
Contributor

ahus1 commented Sep 2, 2022

@iankko - thanks for handling this, I wasn't able to react the ping on GithHub you sent yesterday. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants