Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHSSO-2203] Ensure expiry works in Infinispan #262

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[RHSSO-2203] Ensure expiry works in Infinispan #262

merged 1 commit into from
Oct 13, 2022

Conversation

iankko
Copy link
Collaborator

@iankko iankko commented Oct 5, 2022

Note: Same logic PR like in the case of RHSSO-1937, but applied against RH-SSO 7.6.X image this time

[RHSSO-2203] Ensure expiry works in Infinispan

Setting any lifespan will enable the Infinispan reaper process to remove expired entries. This avoids an OOM situation.

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@ahus1
[RHSSO-2203] Ensure expiry works in Infinispan
8ce3110 
Setting any lifespan will enable the Infinispan reaper process to remove expired entries. This avoids an OOM situation.

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@iankko iankko added the rh-sso-7.6.1 Candidate change to be possibly included into RH-SSO 7.6.1 release label Oct 5, 2022
@iankko iankko requested review from ASzc and drichtarik October 5, 2022 14:41
@iankko iankko self-assigned this Oct 5, 2022
@drichtarik
Copy link
Collaborator

Was there a test run?

drichtarik
drichtarik approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@drichtarik drichtarik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge possible if it was tested in our custom pipeline

@iankko
Copy link
Collaborator Author

iankko commented Oct 13, 2022

@drichtarik Thanks for the review, Denis! (merging, so I can test changes from all PRs as a whole)

@iankko iankko merged commit 404ece0 into jboss-container-images:sso76-dev Oct 13, 2022
@iankko iankko deleted the RHSSO-2203 branch October 13, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drichtarik drichtarik drichtarik approved these changes

@ASzc ASzc Awaiting requested review from ASzc

Assignees

@iankko iankko

Labels
rh-sso-7.6.1 Candidate change to be possibly included into RH-SSO 7.6.1 release
Milestone
No milestone
3 participants
@iankko @drichtarik @ahus1