Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Deploy RH-SSO pod only if DB service is ready #60

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Deploy RH-SSO pod only if DB service is ready #60

wants to merge 2 commits into from

Conversation

iankko
Copy link
Collaborator

@iankko iankko commented Oct 10, 2018

This PR is performing the following:

* [CLOUD-2453][KEYCLOAK-7098] Move description of SSO_ADMIN_USERNAME,
  SSO_ADMIN_PASSWORD, SSO_SERVICE_USERNAME, and SSO_SERVICE_PASSWORD
  variables from image.yaml to os-sso/module.yaml

  These variables aren't used / referenced outside of some of os-sso,
  os-sso71, and os-sso72 modules, and for the future we want one
  common 'os-sso' module, sharing all the parts common to all
  RH-SSO images. This move is part of such unification

* [CLOUD-2453][KEYCLOAK-7098] Deploy RH-SSO pod only if DB
  service is ready, when provisioning from DB RH-SSO templates

Note: It is a replacement one for jboss-openshift/application-templates#485 one (since the RH-SSO 7.2 templates were moved, the changes need to be done against new location)

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

SSO_ADMIN_PASSWORD, SSO_SERVICE_USERNAME, and SSO_SERVICE_PASSWORD
variables from image.yaml to os-sso/module.yaml

These variables aren't used / referenced outside of some of os-sso,
os-sso71, and os-sso72 modules, and for the future we want one
common 'os-sso' module, sharing all the parts common to all
RH-SSO images. This move is part of such unification

Signed-off-by: Jan Lieskovsky <jlieskov@redhat.com>
service is ready, when provisioning from DB RH-SSO templates

Signed-off-by: Jan Lieskovsky <jlieskov@redhat.com>
@iankko
Copy link
Collaborator Author

iankko commented Oct 10, 2018

The PR was updated, and should be ready for re-review.

@iankko iankko requested a review from rcernich October 10, 2018 19:02
@iankko iankko changed the title [CLOUD-2453][KEYCLOAK-7098] Deploy RH-SSO pod only if DB service is ready [DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Deploy RH-SSO pod only if DB service is ready Oct 11, 2018
@iankko iankko closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants