Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-453] - Adapt product artifacts definitions to CPaaS build #402

Merged
merged 3 commits into from
Nov 20, 2020
Merged

[KIECLOUD-453] - Adapt product artifacts definitions to CPaaS build #402

merged 3 commits into from
Nov 20, 2020

Conversation

spolti
Copy link
Member

@spolti spolti commented Nov 16, 2020 •
edited

Signed-off-by: spolti fspolti@redhat.com

See: https://issues.redhat.com/browse/KIECLOUD-453

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHDM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@spolti spolti added the 7.12.x ⇨ 7.12.0 7.12.x branch work for version 7.12.0 release label Nov 16, 2020
@kie-ci-bot kie-ci-bot bot added the needs review 🔍 Pull Request that needs reviewers label Nov 16, 2020
msmagnanijr
msmagnanijr previously approved these changes Nov 16, 2020
View reviewed changes
Kaitou786
Kaitou786 previously approved these changes Nov 17, 2020
View reviewed changes
jakubschwan
jakubschwan previously approved these changes Nov 18, 2020
View reviewed changes
@spolti spolti changed the title [KIECLOUD-453] - Use unique names for product artifacts [KIECLOUD-453] - Adapt product artifacts definitions to CPaaS build Nov 18, 2020
@kie-ci-bot
Copy link

kie-ci-bot bot commented Nov 18, 2020

Change detected in the PR

msmagnanijr
msmagnanijr previously approved these changes Nov 18, 2020
View reviewed changes
jakubschwan
jakubschwan requested changes Nov 19, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Kaitou786
Kaitou786 previously approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@Kaitou786 Kaitou786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after Jakub suggestions

@spolti @jakubschwan
fix typo
f0b0d92 
Co-authored-by: Jakub Schwan <jschwan@redhat.com>
@spolti spolti dismissed stale reviews from Kaitou786 and msmagnanijr via f0b0d92 November 19, 2020 18:18
@kie-ci-bot
Copy link

kie-ci-bot bot commented Nov 19, 2020

Change detected in the PR

1 similar comment
@kie-ci-bot
Copy link

kie-ci-bot bot commented Nov 19, 2020

Change detected in the PR

@spolti @jakubschwan
fix typo
2951786 
Co-authored-by: Jakub Schwan <jschwan@redhat.com>
@kie-ci-bot
Copy link

kie-ci-bot bot commented Nov 19, 2020

Change detected in the PR

@spolti spolti added ready 🚀 work completed and ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Nov 19, 2020
@spolti spolti merged commit 0cec874 into jboss-container-images:master Nov 20, 2020
@spolti spolti deleted the KIECLOUD-453 branch November 20, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmagnanijr msmagnanijr msmagnanijr approved these changes

@jakubschwan jakubschwan jakubschwan approved these changes

@Kaitou786 Kaitou786 Kaitou786 approved these changes

@desmax74 desmax74 Awaiting requested review from desmax74

@almope almope Awaiting requested review from almope

@AntStephenson AntStephenson Awaiting requested review from AntStephenson

Assignees
No one assigned
Labels
7.12.x ⇨ 7.12.0 7.12.x branch work for version 7.12.0 release ready 🚀 work completed and ready to be merged
Milestone
No milestone
4 participants
@spolti @msmagnanijr @jakubschwan @Kaitou786