[KIECLOUD-114] Remove app label from authoring HA template #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some discussion, instead of adding app labels in all templates, we decided to remove the app labels as they are automatically generated by OpenShift. Although I still believe we must change the application label to another thing as app and application labels semantically mean the same. Signed-off-by: rimolive <ricardo.martinelli.oliveira@gmail.com>
spolti
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link: https://issues.jboss.org/browse/KIECLOUD-114
After some discussion, instead of adding app labels in all templates, we decided to remove the app labels as they are automatically generated by OpenShift. Although I still believe we must change the application
label to another thing as app and application labels semantically mean the same.
Signed-off-by: rimolive ricardo.martinelli.oliveira@gmail.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[RHDM-XYZ] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s