Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHDM-870] Fix AMQ ping service name #213

Merged
merged 1 commit into from Mar 11, 2019
Merged

[RHDM-870] Fix AMQ ping service name #213

merged 1 commit into from Mar 11, 2019

Conversation

rimolive
Copy link
Contributor

JIRA Link: https://issues.jboss.org/browse/RHDM-870

"ping" must be used as Service name as AMQ clustering configuration hard-coded this name.

Signed-off-by: rimolive ricardo.martinelli.oliveira@gmail.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHDM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@errantepiphany errantepiphany self-requested a review March 11, 2019 18:51
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to change as well?

              {
                "name": "OPENSHIFT_DNS_PING_SERVICE_NAME",
                "value": "${APPLICATION_NAME}-amq-ping"
              },

ping must be used as Service name as AMQ clustering configuration hard-coded this name.

Signed-off-by: rimolive <ricardo.martinelli.oliveira@gmail.com>
@errantepiphany errantepiphany merged commit 2858545 into jboss-container-images:7.3.x Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants