Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-181] Add JDK 11 compatibility with quickstarter #235

Merged

Conversation

ricardozanini
Copy link
Contributor

Signed-off-by: Ricardo Zanini zanini@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHDM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@ricardozanini
Copy link
Contributor Author

I tried to clean up this conflict locally after syncing my master and feature branch with upstream and went ok. Squashed and force pushed, but idk why github doesn't want to solve it. it's pretty simple to solve, just remove the end tag </project>. :(

@errantepiphany errantepiphany added master ⇨ 7.4.0 ready 🚀 work completed and ready to be merged labels Apr 16, 2019
@errantepiphany errantepiphany self-requested a review April 16, 2019 22:26
@errantepiphany errantepiphany merged commit 9f94b52 into jboss-container-images:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready 🚀 work completed and ready to be merged
2 participants