Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHDM-894] Update RHDM images to use RHEL8 (UBI) base layer #242

Merged
merged 1 commit into from May 13, 2019
Merged

[RHDM-894] Update RHDM images to use RHEL8 (UBI) base layer #242

merged 1 commit into from May 13, 2019

Conversation

errantepiphany
Copy link
Collaborator

[RHDM-894] Update RHDM images to use RHEL8 (UBI) base layer
https://issues.jboss.org/browse/RHDM-894

Signed-off-by: David Ward dward@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHDM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@errantepiphany errantepiphany added master ⇨ 7.4.0 wip 🚧 work in progress and not ready to be merged labels May 7, 2019
@errantepiphany errantepiphany requested a review from spolti May 7, 2019 09:06
spolti
spolti reviewed May 8, 2019
View reviewed changes
controller/image.yaml Outdated Show resolved Hide resolved
spolti
spolti reviewed May 8, 2019
View reviewed changes
controller/branch-overrides.yaml
# url: https://github.com/jboss-container-images/jboss-eap-modules.git
url: https://github.com/luck3y/jboss-eap-modules.git
# TODO: replace with GA tag when available
ref: 7.2.x-openjdk11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observation made on PAM pr.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reply made on PAM pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if the related changes be merged on EAP branch today?

@errantepiphany errantepiphany added ready 🚀 work completed and ready to be merged and removed wip 🚧 work in progress and not ready to be merged labels May 8, 2019
@errantepiphany
[RHDM-894] Update RHDM images to use RHEL8 (UBI) base layer
57e3150 
Signed-off-by: David Ward <dward@redhat.com>
@errantepiphany errantepiphany merged commit fa56abb into jboss-container-images:master May 13, 2019
@errantepiphany errantepiphany deleted the RHDM-894_master branch May 13, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolti spolti spolti left review comments

Assignees
No one assigned
Labels
ready 🚀 work completed and ready to be merged
Milestone
No milestone
2 participants
@errantepiphany @spolti