Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-346] Editorial changes: username to user name and typos #315

Merged
merged 1 commit into from Dec 4, 2019
Merged

[KIECLOUD-346] Editorial changes: username to user name and typos #315

merged 1 commit into from Dec 4, 2019

Conversation

mramendi
Copy link
Contributor

@mramendi mramendi commented Dec 3, 2019

https://issues.jboss.org/browse/KIECLOUD-346

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHDM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

errantepiphany
errantepiphany previously approved these changes Dec 3, 2019
View reviewed changes
@errantepiphany errantepiphany added 7.6.x ⇨ 7.6.0 ready 🚀 work completed and ready to be merged labels Dec 3, 2019
spolti
spolti previously approved these changes Dec 3, 2019
View reviewed changes
@mramendi mramendi dismissed stale reviews from spolti and errantepiphany via fa2792c December 3, 2019 20:57
errantepiphany
errantepiphany requested changes Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mramendi Looks good, please just squash the 2 commits into 1. Thanks!

@mramendi
username to user name and typos
8ef6027 
Signed-off-by: Mikhail Ramendik <mramendi@redhat.com>
@mramendi
Copy link
Contributor Author

mramendi commented Dec 3, 2019

@mramendi Looks good, please just squash the 2 commits into 1. Thanks!

Squashed

@errantepiphany errantepiphany merged commit 38ad536 into jboss-container-images:7.6.x Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errantepiphany errantepiphany errantepiphany approved these changes

@spolti spolti spolti left review comments

Assignees
No one assigned
Labels
ready 🚀 work completed and ready to be merged
Milestone
No milestone
3 participants
@mramendi @errantepiphany @spolti