Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-411] - Prepare RHPAM and RHDM repositories for next version… #363

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

spolti
Copy link
Member

@spolti spolti commented Aug 3, 2020

… iteration

Signed-off-by: spolti fspolti@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@@ -1,4 +1,4 @@
@rhpam-7/rhpam78-businesscentral-monitoring
@rhpam-7/rhpam7.9-businesscentral-monitoring

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be '.', right?

Suggested change
@rhpam-7/rhpam7.9-businesscentral-monitoring
@rhpam-7/rhpam79-businesscentral-monitoring

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, there should not be 7.9 or 79 in the image name, these tests shouldn't be here anyways. @errantepiphany do you remember why we kept these tests here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to the correct images name.
after we merge this will move these tests to jboss-kie-modules.
@errantepiphany do you agree with it?

… iteration

Signed-off-by: spolti <fspolti@redhat.com>
Copy link

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for me

@spolti spolti merged commit 0427508 into jboss-container-images:master Aug 3, 2020
@spolti spolti deleted the KIECLOUD-411 branch August 3, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready 🚀 work completed and ready to be merged
2 participants