[RHPAM-1361] Add SSO principal-attribute #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
added
the
on hold ⏳
jakubschwan
reviewed
Jul 30, 2018
templates/rhpam70-authoring-ha.yaml
Outdated
| @@ -365,6 +365,10 @@ parameters: | |||
| name: SSO_DISABLE_SSL_CERTIFICATE_VALIDATION | |||
| value: "false" | |||
| required: false | |||
| - displayName: RH-SSO Principal Attribute | |||
| description: RH-SSO Principal Attribute to use as username. Defaults to preferred_username | |||
There was a problem hiding this comment.
This environment variable do not have set default value (value: "preferred_username"). From the jira description CLOUD-2722 I would expect, that for an empty value of the SSO_PRINCIPAL_ATTRIBUTE parameter is used as default value "sub". @ruromero please, can you add the default value for all templates?
There was a problem hiding this comment.
@jakubschwan once the PR for CLOUD-2722 is merged I’ll apply the changes
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
|
@spolti can you remove the on hold label? It should be OK to merge now. |
spolti
removed
the
on hold ⏳
|
@ruromero please create also PR with changes for 7.1 branch |
|
@jakubschwan done here #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Romero Montes rromerom@redhat.com
Fixes https://issues.jboss.org/browse/RHPAM-1361
Depends on jboss-openshift/cct_module#270