Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update imagestreams to registry.redhat.io #121

Merged
merged 1 commit into from Aug 20, 2018

Conversation

bparees
Copy link

@bparees bparees commented Aug 15, 2018

No description provided.

@bparees
Copy link
Author

bparees commented Aug 15, 2018

@spolti these changes are needed to switch to the new redhat registry. Since openshift/library is pulling from a specific tag you have created in this repo, you'll need to get these changes associated w/ the tag you are using (7.0.0.GA) or update official.yaml in openshift/library to pull from a different branch/tag that has these changes.

@spolti
Copy link
Member

spolti commented Aug 16, 2018

@bparees these changes can wait for our next sprint to get done?
I think it will happen next week, @errantepiphany is that right?

@bparees
Copy link
Author

bparees commented Aug 16, 2018

@spolti yes there is no immediate urgency, i'm just trying to get this off my todo list (making sure everyone's imagestreams are updated properly) so the sooner the better from that perspective, but nothing is going to break imminently.

@spolti
Copy link
Member

spolti commented Aug 16, 2018

@bparees ok, we will target this to the next sprint, I preparing a PR for openshift-ansible to update the templates for the latest version (7.0.2) and for the next release, we will address these changes.
Thanks.

@spolti
Copy link
Member

spolti commented Aug 16, 2018

targeted to the active sprint: https://issues.jboss.org/browse/RHPAM-1471

@errantepiphany
Copy link
Collaborator

@bparees @spolti I see this PR is against rhpam70, which is the release branch for 7.0. This should instead go on rhpam70-dev, and we merge to rhpam70 on release. That being said, does this need to go into a forthcoming 7.0 release? Whether or not it is, I think we'll need another PR for the rhpam71-dev branch, toward 7.1.0.GA. Thanks!

@spolti
Copy link
Member

spolti commented Aug 16, 2018

@errantepiphany good catch, I think we could merge this only on rhpam71-dev branch.

@bparees
Copy link
Author

bparees commented Aug 16, 2018

@errantepiphany @spolti I leave it up to you guys to get this into the right branch+tag. You can cherry-pick this commit and close this PR or whatever you want to do. But as i noticed in my PR, openshift/library is pulling from the 7.0.0.GA tag currently.

If you're going to put these changes into rhpam71-dev (and then rhpam71?) then you'll need to update openshift/library to pull from the appropriate branch or tag that you create that includes the changes:

https://github.com/openshift/library/blob/master/official.yaml#L543
https://github.com/openshift/library/blob/master/official.yaml#L9

The important thing is that your imagestreams point to the new registry and set the reference policy to local, and that openshift/library picks up those changes.

@errantepiphany errantepiphany merged commit 63bf031 into jboss-container-images:rhpam70 Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants