[RHPAM-1435] CE build alignment for EAP-based OpenShift images in RHPAM #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errantepiphany
added
the
on hold ⏳
|
Note: This PR depends upon jboss-container-images/jboss-kie-modules#70 |
spolti
reviewed
Aug 16, 2018
| @@ -0,0 +1,17 @@ | |||
| schema_version: 1 | |||
|
|
|||
| from: "rhpam-7/rhpam71-businesscentral-indexing:latest" | |||
There was a problem hiding this comment.
As the indexing module changed, shouldn't the image name change to workbench-indexing too?
There was a problem hiding this comment.
No because the product image here is still businesscentral. The reasons the script module changed name is 1) because it's shared between both businesscentral and decisioncentral, and I needed a different name, 2) this work will lead us to community images, where it is actually called workbench.
spolti
approved these changes
Aug 17, 2018
errantepiphany
removed
the
on hold ⏳
errantepiphany
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RHPAM-1435] CE build alignment for EAP-based OpenShift images in RHPAM
https://issues.jboss.org/browse/RHPAM-1435
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s