Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-23] - RoleBinding objects in templates don't contain applic… #167

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

spolti
Copy link
Member

@spolti spolti commented Oct 25, 2018

…ation label and add missing template.alpha.openshift.io/wait-for-ready annotation

Signed-off-by: Filippe Spolti fspolti@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

…ation label and add missing template.alpha.openshift.io/wait-for-ready annotation

Signed-off-by: Filippe Spolti <fspolti@redhat.com>
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, thanks for adding the "wait-for-ready" annotations!

@spolti spolti merged commit f06e4d7 into jboss-container-images:master Oct 25, 2018
@spolti spolti deleted the KIECLOUD-23 branch October 25, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants