Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHPAM-1850] Correct KIE_SERVER_CONTROLLER_PROTOCOL value for Smart r… #223

Merged
merged 1 commit into from Jan 29, 2019

Conversation

sutaakar
Copy link
Contributor

…outer

https://issues.jboss.org/browse/RHPAM-1850

Signed-off-by: Karel Suta ksuta@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

…outer

Signed-off-by: Karel Suta <ksuta@redhat.com>
@sutaakar
Copy link
Contributor Author

@errantepiphany Please take a look.

@errantepiphany
Copy link
Collaborator

@sutaakar So, it looks like the rhpam73-prod.yaml template uses "http" for smartrouter/controller communication, but rhpam73-prod-immutable-monitor.yaml uses "ws". I'm assuming this PR is to make them both the same? I'm curious why "http" for smartrouter/controller communication whereas we use "ws" for kieserver/controller communication. Does is not work otherwise?

@spolti
Copy link
Member

spolti commented Jan 29, 2019

I had the same question, did we decide to use http insteado ws?

@sutaakar
Copy link
Contributor Author

@errantepiphany
Copy link
Collaborator

@sutaakar Awesome, thanks.

@errantepiphany errantepiphany merged commit ee41000 into jboss-container-images:master Jan 29, 2019
@sutaakar sutaakar deleted the RHPAM-1850 branch January 30, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants