[RHPAM-1942] Fix wrong database configuration in rhpam73-authoring-ha… #238
Conversation
|
@errantepiphany Please take a look. |
templates/rhpam73-authoring-ha.yaml
Outdated
| - name: KIE_SERVER_PERSISTENCE_DIALECT | ||
| value: "org.hibernate.dialect.MySQLDialect" | ||
| value: "org.hibernate.dialect.MySQL5Dialect" |
There was a problem hiding this comment.
@sutaakar Ha, I found this error myself when creating the datagrid ha authoring templates. ::) Should we be even more specific, and replace with MySQL57Dialect? Or do you feel MySQL5Dialect is sufficient?
There was a problem hiding this comment.
Well, that is the question, on premise we currently test with MySQL5InnoDBDialect, however I think we can use MySQL57Dialect as it is the most specific one.
There was a problem hiding this comment.
I wonder if we should parameterize the dialect, but default it to MySQL57Dialect to best align with the default that's already there for MYSQL_IMAGE_STREAM_TAG (which is 5.7). But this way, people can change to MySQL5InnoDBDialect if they want. Thoughts?
There was a problem hiding this comment.
Sounds good to me.
I guess this should be reflected on all templates using database, right?
There was a problem hiding this comment.
I do agree we should use 5.7 as it is the default as it match the mysql version we use on OpenShift.
The dialect already is configurable, do you mean set something like MySQL${VERSION}InnoDBDialect?
There was a problem hiding this comment.
Using version placeholder isn't ideal as there is no specific dialect for every database version. For MySQL there is MySQL5Dialect, MySQL55Dialect and MySQL57Dialect.
templates/rhpam73-authoring-ha.yaml
Outdated
| @@ -1189,8 +1189,10 @@ objects: | |||
| value: "${APPLICATION_NAME}-mysql" | |||
| - name: RHPAM_SERVICE_PORT | |||
| value: "3306" | |||
| - name: TIMER_SERVICE_DATA_STORE | |||
There was a problem hiding this comment.
You don't need to set it, it is automatically configured by the EJB timer scripts.
https://github.com/jboss-container-images/jboss-kie-modules/blob/master/jboss-kie-kieserver/added/launch/jboss-kie-kieserver.sh#L88-L100
The reason we set it on the script is to make sure that the datasource used to configure the datastore will be the ejb timer datasource.
There was a problem hiding this comment.
Ok, so the TIMER_SERVICE_DATA_STORE can be removed from all our templates then?
There was a problem hiding this comment.
yes, it will be overridden anyways.
Signed-off-by: Karel Suta <ksuta@redhat.com>
|
PR updated, all dialects now have specific template property. |
|
Follow-up PR is here: #239 |
….yaml
Added missing TIMER_SERVICE_DATA_STORE env variable and updated dialect to org.hibernate.dialect.MySQL5Dialect.
Signed-off-by: Karel Suta ksuta@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[RHPAM-XYZ] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s