Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHBA-724] Added rhpam70-authoring template #25

Merged

Conversation

bmozaffa
Copy link
Contributor

@bmozaffa bmozaffa commented Apr 6, 2018

https://issues.jboss.org/browse/RHBA-724

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

…thoring.yaml

Signed-off-by: Babak Mozaffari <bmozaffa@redhat.com>
@bmozaffa bmozaffa force-pushed the rhpam70-dev branch 4 times, most recently from f5e4924 to 9969c0b Compare April 6, 2018 08:04
…ntials

Signed-off-by: Babak Mozaffari <bmozaffa@redhat.com>
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on admin vs. maven user/pass in relation to RHDM-319.

@@ -626,9 +617,9 @@ objects:
- name: MAVEN_REPO_PATH
value: "/maven2/"
- name: MAVEN_REPO_USERNAME
value: "${MAVEN_REPO_USERNAME}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why it's easier to replace the maven user/pass with the admin user/pass in these lines, because of https://issues.jboss.org/browse/RHDM-319 . However, once that jira is completed, this change will have to get reverted. So, the options are 1) keep it as maven user/pass, and people will have to continue passing in the same args for both admin and maven user/pass until RHDM-319 is fixed, or 2) make these changes here, but then have to revert them to maven user/pass once RHDM-319 is fixed. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that RHDM-319 is forcing us to use admin credentials to authenticate against Maven, and we would want to rectify this as soon as RHDM-319 is resolved. Until then, we have no other option. Reverting the change will just mean providing the admin credentials to the template from outside, but still having to change things around once RHDM-319 is resolved. We would then generate a Maven password that is shared across both services, but the status quo doesn't help with that anyway.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Will now merge, and we'll have to circle back this. Thanks!

@errantepiphany errantepiphany merged commit 29d70c8 into jboss-container-images:rhpam70-dev Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants