-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIECLOUD-181] Refactoring RHPAM quickstarter for JDK 11 compatibility #281
[KIECLOUD-181] Refactoring RHPAM quickstarter for JDK 11 compatibility #281
Conversation
@ricardozanini Please use common IDE formatting configuration if possible - see https://github.com/kiegroup/droolsjbpm-build-bootstrap/tree/master/ide-configuration . |
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
baa06cd
to
3ec3347
Compare
} | ||
context.init(null, new TrustManager[]{ | ||
new X509TrustManager() { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why introduce such a huge indent? Are you using spaces (preferred) or tabs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using spaces and this is a consequence of the droolsjbpm formatter profile. I can revert back to the original one, but will break the formatter profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it's fine. It's that big of a deal to me. :)
new Object[] {"978-1-4516-7486-6", "Tesla, Man Out of Time", "Explores the brilliant and prescient mind of one of the twentieth century's greatest scientists and inventors, Nikola Tesla.", 4}, | ||
new Object[] {"978-1-59474-449-5", "Pride and Prejudice and Zombies", "The Classic Regency Romance -- Now with Ultraviolent Zombie Mayhem!", 7} | ||
private static final Object[][] INIT = new Object[][]{ | ||
new Object[]{"978-0-307-35193-7", "World War Z", "An Oral History of the Zombie War", 1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why introduce such a huge indent? Are you using spaces (preferred) or tabs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. :)
Oops sorry to be redundant. I juts saw Karel's comment about formatting... |
See:
https://issues.jboss.org/browse/KIECLOUD-181
Signed-off-by: Ricardo Zanini zanini@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[RHPAM-XYZ] Subject
CONTRIBUTING.md
)Signed-off-by: Your Name <yourname@example.com>
- usegit commit -s