Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-181] Refactoring RHPAM quickstarter for JDK 11 compatibility #281

Merged

Conversation

ricardozanini
Copy link
Contributor

@ricardozanini ricardozanini commented Apr 15, 2019

See:
https://issues.jboss.org/browse/KIECLOUD-181

Signed-off-by: Ricardo Zanini zanini@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@sutaakar
Copy link
Contributor

@ricardozanini Please use common IDE formatting configuration if possible - see https://github.com/kiegroup/droolsjbpm-build-bootstrap/tree/master/ide-configuration .

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@errantepiphany errantepiphany added master ⇨ 7.4.0 wip 🚧 work in progress and not ready to be merged labels Apr 16, 2019
}
context.init(null, new TrustManager[]{
new X509TrustManager() {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introduce such a huge indent? Are you using spaces (preferred) or tabs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using spaces and this is a consequence of the droolsjbpm formatter profile. I can revert back to the original one, but will break the formatter profile.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it's fine. It's that big of a deal to me. :)

new Object[] {"978-1-4516-7486-6", "Tesla, Man Out of Time", "Explores the brilliant and prescient mind of one of the twentieth century's greatest scientists and inventors, Nikola Tesla.", 4},
new Object[] {"978-1-59474-449-5", "Pride and Prejudice and Zombies", "The Classic Regency Romance -- Now with Ultraviolent Zombie Mayhem!", 7}
private static final Object[][] INIT = new Object[][]{
new Object[]{"978-0-307-35193-7", "World War Z", "An Oral History of the Zombie War", 1},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introduce such a huge indent? Are you using spaces (preferred) or tabs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. :)

@errantepiphany
Copy link
Collaborator

Oops sorry to be redundant. I juts saw Karel's comment about formatting...

@errantepiphany errantepiphany added ready 🚀 work completed and ready to be merged and removed wip 🚧 work in progress and not ready to be merged labels Apr 16, 2019
@errantepiphany errantepiphany merged commit acd4271 into jboss-container-images:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready 🚀 work completed and ready to be merged
4 participants