[RHPAM-724] Added rhpam70-prod-immutable-monitor & rhpam70-prod-immutable-kieserver templates #32
Conversation
|
@sutaakar Here is on with SSO support |
|
@jakubschwan Can you please take a look? |
| value: KIE Server Router | ||
| - displayName: KIE Server Monitor User | ||
| description: KIE server monitor username (Sets the org.kie.server.controller.user system property) | ||
| name: KIE_SERVER_MONITOR_USER |
There was a problem hiding this comment.
What's the reason of renaming KIE_SERVER_CONTROLLER_USER ? I am afraid that this change can be confusing because here in template we set Monitor User but for image we set this Monitor User as Controller User.
There was a problem hiding this comment.
We've been discussing that in production and with immutable images, most customers expect there to not be a "controller". As the name applies, the controller in fact controls what KIE containers are deployed and started on KIE servers, and has to be running for a KIE server to validate its configuration and start up. That is not the case for this template, or at least it won't be after https://issues.jboss.org/browse/RHPAM-794 is merged and effective. I think a better parameter name would solidify this understanding (even if not renamed upstream), but am open to changing it back if I'm in the minority on this.
bmozaffa
force-pushed
the
rhpam70-prod-immutable
branch
from
917dcf7
to
a9f6ebb
Compare
|
@jakubschwan To make sure you don't waste time, let me warn you that in my own validation, the SSO_Client parameter was not effective and it always set the client to "root". This should be resolved with this Pull Request but not sure if it's in our built images yet. |
bmozaffa
force-pushed
the
rhpam70-prod-immutable
branch
from
a9f6ebb
to
8b6fd1a
Compare
bmozaffa
changed the title
|
Updated PR to include rhpam70-prod-immutable-kieserver, and support for RHPAM-794 |
bmozaffa
force-pushed
the
rhpam70-prod-immutable
branch
from
8b6fd1a
to
ef3d189
Compare
bmozaffa
changed the title
|
@jakubschwan , @bmozaffa , @sutaakar : Is this PR ready to be merged? |
| namespace: "${IMAGE_STREAM_NAMESPACE}" | ||
| name: "rhpam70-smartrouter-openshift:${IMAGE_STREAM_TAG}" | ||
| - type: ConfigChange | ||
| replicas: 2 |
There was a problem hiding this comment.
Please remove replicas for now.
Smart Router can't be clustered because watcher is not enabled (org.kie.server.router.config.watcher.enabled) and there is not create shared volume for config file. Reported as https://issues.jboss.org/browse/RHPAM-796
|
@bmozaffa There is a need to add AMQ for Monitorng because now controller is not updated between pods. |
| - name: RHPAM_JTA | ||
| value: "true" | ||
| - name: RHPAM_TX_ISOLATION | ||
| value: "TRANSACTION_READ_UNCOMMITTED" |
There was a problem hiding this comment.
I think it should not be hardcoded, see my comment on #36
There was a problem hiding this comment.
Please see my reply there and let me know what you think.
bmozaffa
force-pushed
the
rhpam70-prod-immutable
branch
from
ef3d189
to
3a8aadb
Compare
|
Pushed to set replicas to 1 for business central and smart router, to allow us to have valid templates for the time being until the HA part is figured out. |
… and rhpam70-prod-immutable-kieserver.yaml, with support for RHPAM-794 Signed-off-by: Babak Mozaffari <bmozaffa@redhat.com>
bmozaffa
force-pushed
the
rhpam70-prod-immutable
branch
from
3a8aadb
to
b0e51d7
Compare
https://issues.jboss.org/browse/RHBA-724
Signed-off-by: Babak Mozaffari bmozaffa@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@example.com>- usegit commit -s