Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHPAM-2175] Drop EXTERNAL_AUTH_ONLY #415

Merged
merged 1 commit into from Feb 10, 2020
Merged

[RHPAM-2175] Drop EXTERNAL_AUTH_ONLY #415

merged 1 commit into from Feb 10, 2020

Conversation

ruromero
Copy link
Contributor

@ruromero ruromero commented Feb 5, 2020

@ruromero
[RHPAM-2175] Drop EXTERNAL_AUTH_ONLY
1fb7f72 
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@Sgitario
Copy link
Contributor

Sgitario commented Feb 6, 2020

Hi @ruromero , I'm missing the changes for dropping the external auth only param in the operator as well in files:

  • common.yaml
  • kieapp.crd
  • form.json
  • auth.go
  • auth_test.go

and maybe more...

Were you planning to add those changes as part of another PR or in this PR?

@ruromero
Copy link
Contributor Author

ruromero commented Feb 6, 2020

Hey @Sgitario it is already merged kiegroup/kie-cloud-operator#355

@spolti
Copy link
Member

spolti commented Feb 7, 2020

Waiting similar RHDM PR to merge this one.

@spolti spolti added the on hold ⏳ work completed but not ready to be merged until some other condition is met label Feb 7, 2020
@spolti spolti merged commit 748f8f4 into jboss-container-images:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolti spolti spolti approved these changes

Assignees
No one assigned
Labels
on hold ⏳ work completed but not ready to be merged until some other condition is met
Milestone
No milestone
3 participants
@ruromero @Sgitario @spolti