Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHPAM-263] fix for Liveness probe for Business Central #44

Merged
merged 1 commit into from Apr 24, 2018
Merged

Conversation

calvinzhuca
Copy link
Contributor

@calvinzhuca calvinzhuca commented Apr 24, 2018

Signed-off-by: calvin zhu calvinzhu@hotmail.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

… readiness probe's setting

The container will start to check the availability of BC after 1 minute, instead of 3 minute, if it's ready, then it will start to server request. If it's not ready, it will be checked again after 30 seconds, for up to total 6 times. In this way, the client don't have to wait for 3 minutes if the pod can be ready earlier.

Signed-off-by: calvin zhu <calvinzhu@hotmail.com>
@calvinzhuca
Copy link
Contributor Author

calvinzhuca commented Apr 24, 2018

https://issues.jboss.org/browse/RHPAM-263

This PR is to address feedback: "isn't 180 second initial delay too much? From my own experience the Workbench usually starts in around 60-70 seconds."

Further tune readiness probe's setting

The container will start to check the availability of BC after 1 minute, instead of 3 minute, if it's ready, then it will start to server request. If it's not ready, it will be checked again after 30 seconds, for up to total 6 times. In this way, the client don't have to wait for 3 minutes if the pod can be ready earlier.

@errantepiphany errantepiphany merged commit 399d521 into jboss-container-images:rhpam70-dev Apr 24, 2018
@calvinzhuca calvinzhuca deleted the RHPAM-263-2 branch April 24, 2018 22:49
@sutaakar
Copy link
Contributor

@calvinzhuca Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants