Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-411] - Prepare RHPAM and RHDM repositories for next version… #453

Merged
merged 1 commit into from
Aug 3, 2020
Merged

[KIECLOUD-411] - Prepare RHPAM and RHDM repositories for next version… #453

merged 1 commit into from
Aug 3, 2020

Conversation

spolti
Copy link
Member

@spolti spolti commented Jul 31, 2020

… iteration

Signed-off-by: spolti fspolti@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@spolti spolti added ready 🚀 work completed and ready to be merged master ⇨ 7.9.0 labels Jul 31, 2020
@spolti
Copy link
Member Author

spolti commented Jul 31, 2020

once jboss-container-images/jboss-kie-modules#375 is merged I'll update the adoc files.

jakubschwan
jakubschwan requested changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image streams file is not fully updates.

Shouldn't be also updated name of templates/docs/ files? Right now the file name still have 7.8 version.

rhpam79-image-streams.yaml Show resolved Hide resolved
@spolti
[KIECLOUD-411] - Prepare RHPAM and RHDM repositories for next version…
29671af 
… iteration

Signed-off-by: spolti <fspolti@redhat.com>
jakubschwan
jakubschwan approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for me

@spolti spolti merged commit 68804ff into jboss-container-images:master Aug 3, 2020
@spolti spolti deleted the KIECLOUD-411 branch August 3, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubschwan jakubschwan jakubschwan approved these changes

@desmax74 desmax74 Awaiting requested review from desmax74

@errantepiphany errantepiphany Awaiting requested review from errantepiphany

Assignees
No one assigned
Labels
ready 🚀 work completed and ready to be merged
Milestone
No milestone
2 participants
@spolti @jakubschwan