Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHPAM-802] Pass on router config to images, further cleanup #57

Merged

Conversation

bmozaffa
Copy link
Contributor

@bmozaffa bmozaffa commented May 4, 2018

Ruben: Sort env vars and remove https from trial
Babak: Pass on smart router config to images

Signed-off-by: Babak Mozaffari bmozaffa@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

Babak: Pass on smart router config to images

Signed-off-by: Babak Mozaffari <bmozaffa@redhat.com>
@errantepiphany errantepiphany self-requested a review May 4, 2018 19:57
@errantepiphany errantepiphany merged commit 8217bf4 into jboss-container-images:rhpam70-dev May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants